From 3e08e249310074171716b8f8b085d38969d6eaef Mon Sep 17 00:00:00 2001 From: Armando Navarro Date: Fri, 6 Nov 2026 17:32:43 -0800 Subject: [PATCH] test: let the node specs import the built library The Node jasmine run loads every spec with import(), so an import of @angular/fire looked for an installed package and found none. A resolve hook, preloaded with --import, maps @angular/fire and its entries to the files the built exports map names under dist/packages-dist. Nothing is written into node_modules, and the library's own firebase/app import resolves to the same copy the spec uses. --- package.json | 4 ++-- src/app/runner-spike.jasmine.ts | 14 ++++++++++++++ tools/angular-fire-resolve-hook.mjs | 25 +++++++++++++++++++++++++ tools/jasmine-register-angular-fire.mjs | 8 ++++++++ 4 files changed, 49 insertions(+), 2 deletions(-) create mode 100644 src/app/runner-spike.jasmine.ts create mode 100644 tools/angular-fire-resolve-hook.mjs create mode 100644 tools/jasmine-register-angular-fire.mjs diff --git a/package.json b/package.json index 06adec1d5..4d9564335 100644 --- a/package.json +++ b/package.json @@ -17,8 +17,8 @@ "test:firefox-headless": "npx --yes firebase-tools@latest emulators:exec --project=demo-123 \"ng test --watch=false --browsers=FirefoxHeadless\"", "lint": "ng lint", "lint:fix": "ng lint --fix", - "test:node": "node -r tsconfig-paths/register ./dist/out-tsc/jasmine/tools/jasmine.mjs --input-type=commonjs", - "test:node-esm": "node -r tsconfig-paths/register ./dist/out-tsc/jasmine/tools/jasmine.mjs", + "test:node": "node --import ./tools/jasmine-register-angular-fire.mjs -r tsconfig-paths/register ./dist/out-tsc/jasmine/tools/jasmine.mjs --input-type=commonjs", + "test:node-esm": "node --import ./tools/jasmine-register-angular-fire.mjs -r tsconfig-paths/register ./dist/out-tsc/jasmine/tools/jasmine.mjs", "test:typings": "node ./tools/run-typings-test.js", "test:build": "bash ./test/ng-build/build.sh", "test:all": "npm run test:node-esm && npm run test:chrome-headless && npm run test:typings && npm run test:build", diff --git a/src/app/runner-spike.jasmine.ts b/src/app/runner-spike.jasmine.ts new file mode 100644 index 000000000..c795599e5 --- /dev/null +++ b/src/app/runner-spike.jasmine.ts @@ -0,0 +1,14 @@ +import { TestBed } from '@angular/core/testing'; +import { FirebaseApp, provideFirebaseApp } from '@angular/fire/app'; +import { getApp, initializeApp } from 'firebase/app'; + +describe('Node runner spike', () => { + afterEach(() => TestBed.resetTestingModule()); + + it('loads the built library with one firebase/app registry', () => { + TestBed.configureTestingModule({ + providers: [provideFirebaseApp(() => initializeApp({ apiKey: 'spike', projectId: 'spike', appId: '1:1:web:spike' }, 'spike'))], + }); + expect(TestBed.inject(FirebaseApp)).toBe(getApp('spike')); + }); +}); diff --git a/tools/angular-fire-resolve-hook.mjs b/tools/angular-fire-resolve-hook.mjs new file mode 100644 index 000000000..0c1c512dd --- /dev/null +++ b/tools/angular-fire-resolve-hook.mjs @@ -0,0 +1,25 @@ +// Node resolve hook for the jasmine run: maps @angular/fire imports to the built library under +// dist/packages-dist through its exports map, since nothing installs the package into node_modules. +import { readFileSync } from 'node:fs'; + +const packageName = '@angular/fire'; + +let packageRoot; +let exportsMap; + +export function initialize(data) { + packageRoot = data.packageRoot; + exportsMap = JSON.parse(readFileSync(new URL('package.json', packageRoot), 'utf8')).exports; +} + +export function resolve(specifier, context, nextResolve) { + if (specifier !== packageName && !specifier.startsWith(`${packageName}/`)) { + return nextResolve(specifier, context); + } + const subpath = specifier === packageName ? '.' : `./${specifier.slice(packageName.length + 1)}`; + const entry = exportsMap[subpath]?.default; + if (typeof entry !== 'string') { + throw new Error(`The built ${packageName} has no "${subpath}" entry in its exports map, so "${specifier}" cannot be resolved for the Node specs.`); + } + return { url: new URL(entry, packageRoot).href, shortCircuit: true, format: 'module' }; +} diff --git a/tools/jasmine-register-angular-fire.mjs b/tools/jasmine-register-angular-fire.mjs new file mode 100644 index 000000000..68577f837 --- /dev/null +++ b/tools/jasmine-register-angular-fire.mjs @@ -0,0 +1,8 @@ +// Preloaded by the test:node scripts with --import, before jasmine imports any spec. +import { register } from 'node:module'; +import { resolve } from 'node:path'; +import { pathToFileURL } from 'node:url'; + +register('./angular-fire-resolve-hook.mjs', import.meta.url, { + data: { packageRoot: pathToFileURL(resolve('dist/packages-dist') + '/').href }, +});