From 6fa7c7a1a4061e9c31d31e281e9aed75342133fe Mon Sep 17 00:00:00 2001 From: Joel Dice Date: Thu, 1 Oct 2026 14:27:39 -0600 Subject: [PATCH] use `list(APPEND ...` where appropriate Per https://github.com/WebAssembly/wasi-sdk/pull/660#discussion_r4159530871 --- .github/workflows/main.yml | 2 +- tests/CMakeLists.txt | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7b7b32543..233533633 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -117,7 +117,7 @@ jobs: run: ./ci/docker-build.sh ${{ matrix.artifact }} if: runner.os == 'Linux' - # Setup the VS Developoer Prompt environment variables to explicitly use + # Setup the VS Developer Prompt environment variables to explicitly use # MSVC to compile LLVM as that avoids extra runtime dependencies # msys/mingw might bring. # diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 8231e7629..941fdf09d 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -92,17 +92,17 @@ function(add_testcase test) # Apply test-specific compile options and link flags. if(${arg_EMULATED_CLOCKS}) - set(so_files ${so_files} "${wasi_sysroot}/lib/${target}/libwasi-emulated-process-clocks.so") + list(APPEND so_files "${wasi_sysroot}/lib/${target}/libwasi-emulated-process-clocks.so") target_compile_options(${target_name} PRIVATE -D_WASI_EMULATED_PROCESS_CLOCKS) target_link_options(${target_name} PRIVATE -lwasi-emulated-process-clocks) endif() if(${arg_EMULATED_MMAN}) - set(so_files ${so_files} "${wasi_sysroot}/lib/${target}/libwasi-emulated-mman.so") + list(APPEND so_files "${wasi_sysroot}/lib/${target}/libwasi-emulated-mman.so") target_compile_options(${target_name} PRIVATE -D_WASI_EMULATED_MMAN) target_link_options(${target_name} PRIVATE -lwasi-emulated-mman) endif() if(${arg_EMULATED_SIGNAL}) - set(so_files ${so_files} "${wasi_sysroot}/lib/${target}/libwasi-emulated-signal.so") + list(APPEND so_files "${wasi_sysroot}/lib/${target}/libwasi-emulated-signal.so") target_compile_options(${target_name} PRIVATE -D_WASI_EMULATED_SIGNAL) target_link_options(${target_name} PRIVATE -lwasi-emulated-signal) endif() @@ -113,20 +113,20 @@ function(add_testcase test) # Apply language-specific options and dependencies. if(test MATCHES "cc$") if(WASI_SDK_EXCEPTIONS STREQUAL "DUAL") - set(so_files ${so_files} + list(APPEND so_files "${wasi_sysroot}/lib/${target}/eh/libc++.so" "${wasi_sysroot}/lib/${target}/eh/libc++abi.so") else() - set(so_files ${so_files} + list(APPEND so_files "${wasi_sysroot}/lib/${target}/libc++.so" "${wasi_sysroot}/lib/${target}/libc++abi.so") endif() if(NOT (WASI_SDK_EXCEPTIONS STREQUAL "OFF")) if(WASI_SDK_EXCEPTIONS STREQUAL "DUAL") - set(so_files ${so_files} "${wasi_sysroot}/lib/${target}/eh/libunwind.so") + list(APPEND so_files "${wasi_sysroot}/lib/${target}/eh/libunwind.so") else() - set(so_files ${so_files} "${wasi_sysroot}/lib/${target}/libunwind.so") + list(APPEND so_files "${wasi_sysroot}/lib/${target}/libunwind.so") endif() target_compile_options(${target_name} PRIVATE -fwasm-exceptions -mllvm -wasm-use-legacy-eh=false)