Summary
- Pattern:
PHP 8.5
- Error signature:
no_failed_log_output
- Scope: this repo
- Events observed: 2
- Systemic threshold: 2
Resolution
The default branch now contains the focused SSO test repair in merged PR #1749 (f4e9ab38). Its complete PHP 8.2–8.5 matrix passed, including PHP 8.5. No duplicate PR is required.
Why this looks systemic
- The same check/signature failed repeatedly within the notification window.
- This suggests a shared workflow/tooling defect rather than a PR-specific code problem.
Evidence
Root Cause
The PHP 8.5 label is incidental. The SSO default was changed to disabled in #1741, leaving two tests with shared-state and enabled-by-default assumptions. Commit d7ba3b7f on open PR #1724 isolates the relevant settings and redirect hooks; its PHP 8.2–8.5 checks passed.
Worker Guidance
Goal
Restore a passing PHP test matrix by applying the existing isolated SSO test fix without changing production behavior or CI matrix configuration.
Files Scope
tests/WP_Ultimo/SSO/SSO_Coverage_Test.php
tests/WP_Ultimo/SSO/SSO_Extended_Test.php
Files to inspect first
tests/WP_Ultimo/SSO/SSO_Coverage_Test.php — isolate redirect-host filters and the Domain Mapping singleton in the mapped-domain startup test.
tests/WP_Ultimo/SSO/SSO_Extended_Test.php — assert an explicitly filtered enable_sso value rather than assuming the default is enabled.
inc/sso/class-sso.php — confirm the production default is intentionally disabled and must remain unchanged.
Implementation steps
- Reuse the focused test-only changes from
d7ba3b7f rather than recreating them.
- Remove only filters introduced by each test and restore mutated singleton/request state in
finally blocks.
- Replace the stale default-enabled assertion with an explicit
wu_get_setting filter.
- Do not alter production SSO code, test configuration, or workflow files.
Verification
vendor/bin/phpunit --filter 'SSO_Coverage_Test|SSO_Extended_Test'
- Run
vendor/bin/phpcs tests/WP_Ultimo/SSO/SSO_Coverage_Test.php tests/WP_Ultimo/SSO/SSO_Extended_Test.php when Composer dependencies are available.
Runtime testing
No browser or live WordPress runtime testing is expected. The focused WordPress PHPUnit tests exercise the affected startup hooks and settings behavior. Full CI validates PHP 8.2–8.5 after the PR is created.
Brief recovery
Brief recovery was attempted on 2026-09-01. The original signature lacked failed-log detail; direct job inspection identified the two SSO tests and a validated salvage commit.
Signal tag: gh-failure-miner:bcd33885af8c
aidevops.sh v3.32.296 automated scan.
Summary
PHP 8.5no_failed_log_outputResolution
The default branch now contains the focused SSO test repair in merged PR #1749 (
f4e9ab38). Its complete PHP 8.2–8.5 matrix passed, including PHP 8.5. No duplicate PR is required.Why this looks systemic
Evidence
SSO_Coverage_Test::test_startup_loads_domain_mapping_redirect_host_filterandSSO_Extended_Test::test_get_setting_returns_true_for_enable_sso.Root Cause
The PHP 8.5 label is incidental. The SSO default was changed to disabled in #1741, leaving two tests with shared-state and enabled-by-default assumptions. Commit
d7ba3b7fon open PR #1724 isolates the relevant settings and redirect hooks; its PHP 8.2–8.5 checks passed.Worker Guidance
Goal
Restore a passing PHP test matrix by applying the existing isolated SSO test fix without changing production behavior or CI matrix configuration.
Files Scope
tests/WP_Ultimo/SSO/SSO_Coverage_Test.phptests/WP_Ultimo/SSO/SSO_Extended_Test.phpFiles to inspect first
tests/WP_Ultimo/SSO/SSO_Coverage_Test.php— isolate redirect-host filters and the Domain Mapping singleton in the mapped-domain startup test.tests/WP_Ultimo/SSO/SSO_Extended_Test.php— assert an explicitly filteredenable_ssovalue rather than assuming the default is enabled.inc/sso/class-sso.php— confirm the production default is intentionally disabled and must remain unchanged.Implementation steps
d7ba3b7frather than recreating them.finallyblocks.wu_get_settingfilter.Verification
vendor/bin/phpunit --filter 'SSO_Coverage_Test|SSO_Extended_Test'vendor/bin/phpcs tests/WP_Ultimo/SSO/SSO_Coverage_Test.php tests/WP_Ultimo/SSO/SSO_Extended_Test.phpwhen Composer dependencies are available.Runtime testing
No browser or live WordPress runtime testing is expected. The focused WordPress PHPUnit tests exercise the affected startup hooks and settings behavior. Full CI validates PHP 8.2–8.5 after the PR is created.
Brief recovery
Brief recovery was attempted on 2026-09-01. The original signature lacked failed-log detail; direct job inspection identified the two SSO tests and a validated salvage commit.
Signal tag:
gh-failure-miner:bcd33885af8caidevops.sh v3.32.296 automated scan.