Problem
Two hardening/compliance gaps around the attribution cookie:
- Missing
secure flag. CookieHandler::set() builds the cookie with Symfony defaults, where secure resolves to false. On an HTTPS shop the cookie should be marked Secure (httpOnly true and SameSite=Lax defaults are already fine).
- No consent integration / documentation. This is a marketing/tracking cookie under ePrivacy/GDPR, and the conversion ping sends the customer's IP address to a third party. The plugin sets the cookie unconditionally with no consent hook, which merchants in DK/EU need to be aware of.
Suggested fix
- Set
secure: true on the cookie (or make it configurable alongside name/expiry).
- Document the consent/GDPR implications in the README, and/or provide an extension point so integrators can gate the cookie on their consent solution.
Affected code
src/CookieHandler/CookieHandler.php
README.md
Problem
Two hardening/compliance gaps around the attribution cookie:
secureflag.CookieHandler::set()builds the cookie with Symfony defaults, wheresecureresolves tofalse. On an HTTPS shop the cookie should be markedSecure(httpOnlytrue andSameSite=Laxdefaults are already fine).Suggested fix
secure: trueon the cookie (or make it configurable alongside name/expiry).Affected code
src/CookieHandler/CookieHandler.phpREADME.md