Factor out Angular into `languages.angular`

[snoweuph]

I have verified that this feature request has not been made before

• I have checked the issues tab, and did not find a similar feature request. I understand that my issue will be closed if it is a duplicate.

Feature Type

Other

Feature description

The Idea is to split the Angular out of the TypeScript and HTML Language Modules.

This would allow a better readability of those modules and make them more maintainable for the future.

For example, I plan to add in an Angular specific extensions, which would best live under languages.angular.extensions.<angular-nvim>.

Alternatives

Additional Context

Currently the Usage of Angular with NVF looks like this:

{pkgs, ...}: {
  vim = {
    lsp = {
      presets = {
        angular-language-server.enable = true;
        emmet-ls.enable = true;
      };
      servers = {
        angular-language-server.filetypes = ["htmlangular"];
        emmet-ls.filetypes = ["htmlangular"];
      };
    };
    treesitter.grammars = [pkgs.vimPlugins.nvim-treesitter-parsers.angular];
    languages = {
      typescript.lsp.servers = [
        "angular-language-server"
      ];
      # WRONG FT
      # html.lsp.servers = [
      #   "angular-language-server"
      # ];
    };
  };
}

The Problem arises, from the normal HTML Tree-sitter package not supporting the angular extras. That is fixed by pkgs.vimPlugins.nvim-treesitter-parsers.angular which introduces the htmlangular filetype and automatically detects it.

The angular-language-server has to run on the htmlangular files and their respective TypeScript files, to get its full feature support. On Top of that you still need and use the normal TypeScript LSP on TypeScript files.
The angular-language-server in TypeScript just allows jumping between the HTML and TS files, and Gives more accurate Information about References in TypeScript Files, - Including references inside Templates.

Besides the Reason of the extra Tree-sitter, introducing htmlangular, you also don't want angular-language-server mixed into the HTML Module, because only some HTML LSPs work fine with angular Templates. superhtml for example, doesn't, while emmet-ls does.

[snoweuph]

@horriblename @NotAShelf , I would like to hear your opinions on this.

[poseidon-rises]

If no one has any complaints I'll take this over.

[NotAShelf]

Feel free.

[poseidon-rises]

@snoweuph A quick question, as I'm not super familiar with Angular and it's tooling, what LSP or LSPs should the module enable by default?

[snoweuph]

@snoweuph A quick question, as I'm not super familiar with Angular and it's tooling, what LSPs should the module enable by default?

On .html files in an angular project (which can be identified by a root angular.json), you need to change the filetype to htmlangular and atleast register the angular-language-server, preffered also emmet-ls. On ts files in an angular project you need to either register typescript-go or typescript-language-server AND angular-language-server. Because of the complexity this introduced and the sideeffects on html and typescript, I'v opened this thread for discusssion.

[snoweuph]

@poseidon-rises before you waste some time, I really want to hear @horriblename opinion on this, how we could/should best approach this with our current language module approach.

for example, we might not introduce a languages.angularbut a languages.htmlangular, that only adds an auto command to swap from html to htmlangular when needed (though I think nvim-Tree-sitter, already does this currently, but im not sure.) and only registers LSPs to the htmlangular filetype, and just has the angular LSP, and emmet. and keep the angular-lsp as a possible LSP in the typescript language module, due to it also being a possible registration there.

[horriblename]

from angular treesitter:

Since neovim release 0.11.x, the filetype detection for Angular templates is included. It will detect Angular HTML templates, based on it's contents, and set the filetype to htmlangular.

autocmd isn't needed anymore.

Is the typescript file just regular ol' typescript? how do you tell when to attach or not? lspconfig seems to just attach to everything from tsx to regular html to anything in between

I don't really think calling it languages.htmlangular is necessary, I think it's more convenient to have a angular language that works on htmlangular and typeshit