It not possible to create persistent storage on a secondary nvme drive

[markVnl]

A per subject.

To reproduce:
Create a setup one extra nvme drive for persistent storage.
Usually at initial setup storage is setup on the primary drive, if so delete it
Try to setup a new persistent storage on the secondary nvme drive

Expected behavior:
A persistent storage is created on the secondary nvme drive

Actual behavior:
It fails without an error message

Cause:
This fails because the partition naming scheme of a nvme is different from traditional block devices. The partition numbers have a p prefix. Below the offending line that assumes the newly created partition is called {device}1 on nvme’s it is {device}p1.

nethsecurity/packages/ns-storage/files/ns-storage-setup-disk

Line 31 in b9634a2

mkfs.ext4 -q -F -L ns_data "$device"1 >/dev/null

OT
This issue is a bit tongue in cheek as the same applies to EMMC’s and SD-Cards; which are as you know often used in arm devices. If this issue is addressed it would be nice to improve the workaround in ns-storage-setup-partition too:

nethsecurity/packages/ns-storage/files/ns-storage-setup-partition

Line 34 in 371e492

if [[ "$dev" =~ ^/dev/nvme ]]; then

Here my proposal:
markVnl@21e952c

[gsanchietti]

Thank you @markVnl, I've created a PR with your commit: #1873
I've just changed the commit message to follow the conventional commit standard.