Merge pull request #18 from NativeScript/fix/dotnet-bridge-warnings

fix: silence dotnet-bridge build warnings

Author: triniwiz

dotnet-bridge/Bridge.Dispatch.cs

@@ -351,7 +351,7 @@ private static DispatchResult Box(object? value)
             : DispatchResult.Handle(id, typeName);
     }
 
-    private static bool IsAwaitable(object value, Type t)
+    private static bool IsAwaitable(object? value, Type t)
     {
         if (value is Task || value is ValueTask) return true;
         if (t.IsGenericType && t.GetGenericTypeDefinition() == typeof(ValueTask<>)) return true;

dotnet-bridge/Bridge.Proxy.cs

@@ -421,7 +421,6 @@ private static DispatchResult CreateJsSubclass(
             // look up or dynamically emit a proxy for the correct base class.
             string? resolveFrom = typeName;
             if (!string.IsNullOrEmpty(assemblyName)
-                && typeName != null
                 && typeName.StartsWith("com.tns.gen.winrt.", StringComparison.Ordinal))
             {
                 resolveFrom = assemblyName;

dotnet-bridge/Bridge.cs

@@ -115,7 +115,7 @@ public static string GetNamespaceAssemblyMapJson()
                             var simple = Path.GetFileNameWithoutExtension(file);
                             if (string.IsNullOrEmpty(simple)) continue;
 
-                            Assembly asm = AppDomain.CurrentDomain.GetAssemblies()
+                            Assembly? asm = AppDomain.CurrentDomain.GetAssemblies()
                                 .FirstOrDefault(a => string.Equals(a.GetName().Name, simple, StringComparison.OrdinalIgnoreCase));
                             if (asm is null)
                             {
@@ -540,7 +540,7 @@ public static int RegisterUnhandledExceptionCallback(int callbackId)
                 {
                     var handlerType = ev.EventHandlerType;
                     var method = typeof(Bridge).GetMethod(nameof(CoreApplicationUnhandledErrorHandler), BindingFlags.NonPublic | BindingFlags.Static);
-                    if (method != null)
+                    if (handlerType != null && method != null)
                     {
                         var del = Delegate.CreateDelegate(handlerType, method);
                         ev.AddEventHandler(null, del);
@@ -633,7 +633,7 @@ private static IntPtr ObtainNativePtr(object obj)
         try
         {
             var iidLocal = s_iidIInspectable;
-            var hr = Marshal.QueryInterface(iunknown, ref iidLocal, out var inspectable);
+            var hr = Marshal.QueryInterface(iunknown, in iidLocal, out var inspectable);
             if (hr == 0 && inspectable != IntPtr.Zero)
             {
                 Marshal.Release(iunknown);

dotnet-bridge/DotNetBridge.csproj

@@ -16,6 +16,14 @@
          host process is already running on net10. LatestMajor accepts any version >= 9. -->
     <RollForward>LatestMajor</RollForward>
   </PropertyGroup>
+  <ItemGroup>
+    <!-- The bridge only runs inside a Windows host, but the TFM stays plain net9.0 so the
+         net9.0 test/benchmark projects can reference it. Declaring the platform here keeps
+         CA1416 quiet for the Marshal COM APIs. Skipped when an OS-specific TFM already emits it. -->
+    <AssemblyAttribute Include="System.Runtime.Versioning.SupportedOSPlatformAttribute" Condition="'$(TargetPlatformIdentifier)' == ''">
+      <_Parameter1>windows</_Parameter1>
+    </AssemblyAttribute>
+  </ItemGroup>
   <Target Name="WriteDotNetToolDone" AfterTargets="Publish">
     <PropertyGroup>
       <DotNetToolDoneFile>$(MSBuildProjectDirectory)\publish\.dotnet_tool_done</DotNetToolDoneFile>

template/framework/dotnet-bridge/Bridge.Dispatch.cs

@@ -351,7 +351,7 @@ private static DispatchResult Box(object? value)
             : DispatchResult.Handle(id, typeName);
     }
 
-    private static bool IsAwaitable(object value, Type t)
+    private static bool IsAwaitable(object? value, Type t)
     {
         if (value is Task || value is ValueTask) return true;
         if (t.IsGenericType && t.GetGenericTypeDefinition() == typeof(ValueTask<>)) return true;

template/framework/dotnet-bridge/Bridge.Proxy.cs

@@ -421,7 +421,6 @@ private static DispatchResult CreateJsSubclass(
             // look up or dynamically emit a proxy for the correct base class.
             string? resolveFrom = typeName;
             if (!string.IsNullOrEmpty(assemblyName)
-                && typeName != null
                 && typeName.StartsWith("com.tns.gen.winrt.", StringComparison.Ordinal))
             {
                 resolveFrom = assemblyName;

template/framework/dotnet-bridge/Bridge.cs

@@ -115,7 +115,7 @@ public static string GetNamespaceAssemblyMapJson()
                             var simple = Path.GetFileNameWithoutExtension(file);
                             if (string.IsNullOrEmpty(simple)) continue;
 
-                            Assembly asm = AppDomain.CurrentDomain.GetAssemblies()
+                            Assembly? asm = AppDomain.CurrentDomain.GetAssemblies()
                                 .FirstOrDefault(a => string.Equals(a.GetName().Name, simple, StringComparison.OrdinalIgnoreCase));
                             if (asm is null)
                             {
@@ -540,7 +540,7 @@ public static int RegisterUnhandledExceptionCallback(int callbackId)
                 {
                     var handlerType = ev.EventHandlerType;
                     var method = typeof(Bridge).GetMethod(nameof(CoreApplicationUnhandledErrorHandler), BindingFlags.NonPublic | BindingFlags.Static);
-                    if (method != null)
+                    if (handlerType != null && method != null)
                     {
                         var del = Delegate.CreateDelegate(handlerType, method);
                         ev.AddEventHandler(null, del);
@@ -633,7 +633,7 @@ private static IntPtr ObtainNativePtr(object obj)
         try
         {
             var iidLocal = s_iidIInspectable;
-            var hr = Marshal.QueryInterface(iunknown, ref iidLocal, out var inspectable);
+            var hr = Marshal.QueryInterface(iunknown, in iidLocal, out var inspectable);
             if (hr == 0 && inspectable != IntPtr.Zero)
             {
                 Marshal.Release(iunknown);

template/framework/dotnet-bridge/DotNetBridge.csproj

@@ -16,6 +16,14 @@
          host process is already running on net10. LatestMajor accepts any version >= 9. -->
     <RollForward>LatestMajor</RollForward>
   </PropertyGroup>
+  <ItemGroup>
+    <!-- The bridge only runs inside a Windows host, but the TFM stays plain net9.0 so the
+         net9.0 test/benchmark projects can reference it. Declaring the platform here keeps
+         CA1416 quiet for the Marshal COM APIs. Skipped when an OS-specific TFM already emits it. -->
+    <AssemblyAttribute Include="System.Runtime.Versioning.SupportedOSPlatformAttribute" Condition="'$(TargetPlatformIdentifier)' == ''">
+      <_Parameter1>windows</_Parameter1>
+    </AssemblyAttribute>
+  </ItemGroup>
   <Target Name="WriteDotNetToolDone" AfterTargets="Publish">
     <PropertyGroup>
       <DotNetToolDoneFile>$(MSBuildProjectDirectory)\publish\.dotnet_tool_done</DotNetToolDoneFile>