Repository navigation
Remove dead code - #545
Merged
Merged
Remove dead code#545
Conversation
jverzani
commented
Oct 26, 2026
jverzani
commented
Member
- utils.jl: unused StateConverged, sort_smallest, guarded_secant_step, and identify_starting_point(f, a, b, N); drop stale "not used" comment on _unicode_subscript, which is used
- Roots.jl: Base.get_extension fallback, unneeded for julia ≥ 1.10
- convergence.jl: checks for :exact, :converged, :inf_nan, which are never produced
- sidi.jl: branches for more than two initial points (x is always a 2-tuple) and no-op @reset of the in-place updated tableau
- simple.jl: note that secant_method is exported
* utils.jl: unused StateConverged, sort_smallest, guarded_secant_step, and identify_starting_point(f, a, b, N); drop stale "not used" comment on _unicode_subscript, which is used * Roots.jl: Base.get_extension fallback, unneeded for julia ≥ 1.10 * convergence.jl: checks for :exact, :converged, :inf_nan, which are never produced * sidi.jl: branches for more than two initial points (x is always a 2-tuple) and no-op @reset of the in-place updated tableau * simple.jl: note that secant_method is exported Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 88.37% 90.38% +2.00%
==========================================
Files 43 42 -1
Lines 2685 2600 -85
==========================================
- Hits 2373 2350 -23
+ Misses 312 250 -62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.