Skip to content

QA Report: Colour Engineering Toolkit #2191

Description

@xsscx

QA Report: Colour Engineering Toolkit (CET) Issue

2026-08-18 01:35:18 UTC

Proposed Corrections

CIE94 reference weighting

File: ColourEngineeringToolbox/difference/cie94.m
Use reference chroma, rather than mean reference/sample chroma, for the CIE94 chroma and hue scale factors.

References

Confidence: Moderate; The proposed equation matches the published CIE94 formula

Reproduction

% Before: 1.379995536663367
% Proposed: 1.395038867858738
cie94([50 2.6772 -79.7751],[50 0 -82.7485])

Other Findings

  1. d(65) dispatch
    • Currently: Returns Illuminant A
    • Proposed: Returns D65
  2. Invalid difference weights
    • Currently: Undefined kL/weight variables
    • Proposed: Named validation errors
  3. Valid LUT input
    • Currently: Incorrectly rejected
    • Proposed: [0.25 0.50 0.75]
  4. Euclidean dimensions
    • Currently: Unrelated indexing failure
    • Proposed: Named dimension-mismatch error
  5. CIECAM02 Cartesian coordinates
    • Currently: ac/bc disagree with polar conversion
    • Proposed: Match Ccosd(h) and Csind(h)
  6. Inverse CIECAM02 "average"
    • Currently: Undefined variable c
    • Proposed: XYZ round-trip succeeds

Patches

In Process

Metadata

Metadata

Labels

CodexCodex use indicated by MaintainerCopilotCopilot use indicated by MaintainerQAMaintainer indicates topic of Quality AssuranceciContinuous integration workflow changes

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions