Skip to content

TODO: PR #1880 - Add CTest UseLegacyPCS() #2177

Description

@xsscx

Post Merge Report

2026-08-15 11:41:22 UTC

References

#1748

Item 2

So no CTest can exercise UseLegacyPCS() at all — the whole v2 Lab-encoding path is
untested. A real-world CMYK press profile is almost always v2, which is why @xian20020 hits
this on Windows and CI never has. The Testing/ corpus contains no ICC v2 profile at all, so UseLegacyPCS() — the whole
v2 Lab-encoding path — is exercised by nothing in CI. Across all 252 Testing/**/*.icc:
233 v5 + 19 v4, zero v2; tag types 0 mft2, 0 mft1, 21 mAB , 32 mBA , 1 ncl2. That is why the reporter's exact failure could not be reproduced here (details below), and
it is a standing coverage gap larger than this PR. Not filed as a separate issue — flagging
it here for maintainer visibility.

Metadata

Metadata

Labels

QAMaintainer indicates topic of Quality AssuranceTestingCTest, regression, or test coverageciContinuous integration workflow changes

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions