Add 'Active Channels Only' option to APR calculations in Grafana dashboard#519
Open
markettes wants to merge 1 commit into
Open
Add 'Active Channels Only' option to APR calculations in Grafana dashboard#519markettes wants to merge 1 commit into
markettes wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Grafana dashboard toggle to control whether APR/liquidity denominators are computed from only “active” (routed) channels or from all channels in-scope for the selected nodes, enabling better interpretation of APR relative to deployed liquidity.
Changes:
- Updated APR-related Postgres queries to optionally include non-routing channels in the liquidity denominator when
activeChannelsOnly = 0. - Added a new dashboard templating variable Active Channels Only (
activeChannelsOnly) with Yes/No options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "text": "Yes", | ||
| "value": "1" | ||
| }, | ||
| "description": "When set to Yes, aggregate APR denominators only include channels that settled at least one HTLC in the selected window (\"active\" channels). When No, all NodeGuard-managed channels for the selected nodes contribute liquidity, regardless of whether they routed.", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an option to filter APR calculations by active channels in the Grafana dashboard, enhancing data analysis capabilities.