deep_scheme_does_scav_trans is no longer needed

[jimmielin]

Issue Type

Code Clean-up

Issue Description

In convect_deep.F90, there is this bit of code

function deep_scheme_does_scav_trans()
!
! Function called by tphysbc to determine if it needs to do scavenging and convective transport
! or if those have been done by the deep convection scheme. Each scheme could have its own
! identical query function for a less-knowledgable interface but for now, we know that KE
! does scavenging & transport, and ZM doesn't
!

  logical deep_scheme_does_scav_trans

  deep_scheme_does_scav_trans = .false.

  if ( deep_scheme .eq. 'KE' ) deep_scheme_does_scav_trans = .true.

  return

end function deep_scheme_does_scav_trans

deep_scheme no longer supports the 'KE' option. The only values are ZM, off, or CLUBB_SGS. The corresponding if .not. deep_scheme_does_scav_trans clause in physpkg.F90 can also be collapsed to always true.

Will this change answers?

No

Will you be implementing this yourself?

Any CAM SE can do this