Weathermap plugin scroll doesn't work on first click

[mahavirjain98]

When we click on weathermap tab in cacti, scrollbar is not visible at first if there are multiple maps, weathermap needs to be clicked again to see the scrollbar to scroll down to required maps.

[TheWitness]

Can you upload and animated gif of the issue? Also, can you please look for JavaScript errors?

[mahavirjain98]

Please find below snippet of error I saw in debugs.

I managed to fix the issue though, complete path to weathermap.css was missing in file named: weathermap-cacti-plugin.php.

I replaced all the occurrences of || href="css/weathermap.css"/>'; || with || href="' . $config['url_path'] . 'plugins/weathermap/css/weathermap.css"/>'; ||

Pasting the diff of the changes done, please confirm if the fix done to solve my problem was correct.

weathermap]# diff weathermap-cacti-plugin.php weathermap-cacti-plugin.php.old   
267c267
<                       print '<link rel="stylesheet" type="text/css" media="screen" href="' . $config['url_path'] . 'plugins/weathermap/css/weathermap.css"/>';
---
>                       print '<link rel="stylesheet" type="text/css" media="screen" href="css/weathermap.css"/>';
275c275
<               print '<link rel="stylesheet" type="text/css" media="screen" href="' . $config['url_path'] . 'plugins/weathermap/css/weathermap.css"/>';
---
>               print '<link rel="stylesheet" type="text/css" media="screen" href="css/weathermap.css"/>';
298c298
<               print '<link rel="stylesheet" type="text/css" media="screen" href="' . $config['url_path'] . 'plugins/weathermap/css/weathermap.css"/>';
---
>               print '<link rel="stylesheet" type="text/css" media="screen" href="css/weathermap.css"/>';
319c319
<               print '<link rel="stylesheet" type="text/css" media="screen" href="' . $config['url_path'] . 'plugins/weathermap/css/weathermap.css"/>';
---
>               print '<link rel="stylesheet" type="text/css" media="screen" href="css/weathermap.css"/>';

[TheWitness]

Good catch! Can you do a pull request?

[mahavirjain98]

I am new to git and not aware about the process to do it.

[mahavirjain98]

Initiated pull request check if done correctly

[TheWitness]

Great! Welcome to the team then!

[TheWitness]

Fixed by the users kind pull request. Thanks!